-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(playground): add Reset button #10934
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
commented
Apr 19, 2024
github-actions
bot
added
the
merge conflicts 🚧
Please rebase onto or merge the latest main.
label
Apr 23, 2024
This pull request has merge conflicts that must be resolved before it can be merged. |
caugner
force-pushed
the
add-playground-reset-button
branch
from
April 24, 2024 10:45
bad0370
to
4d8d0ee
Compare
github-actions
bot
removed
the
merge conflicts 🚧
Please rebase onto or merge the latest main.
label
Apr 24, 2024
caugner
commented
Apr 30, 2024
caugner
commented
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self-approval, as the changes are straight-forward and the feature was already QA'd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(MP-1064)
Problem
When opening a shared Playground, or a live sample from content, and modifying the code, there is only a "Clear" button (previously called "Reset"), but there is no way to revert the modifications.
Solution
Add a "Reset" button that resets the content to the inital values (from the shared Playground or the live sample).
Screenshots
Before
After
How did you test this change?
Tested on stage with these examples:
After loading, I changed some code, clicked the "Reset" button, confirmed, and verified that the original version of the Playground Share / Live Sample was shown again.