Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflows): cache @vscode/ripgrep bin in test job #10471

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Feb 6, 2024

Summary

Follow-up PR to #10456.

Problem

In #10456, I added the caching step to every non-build workflow, but forgot to add it to the second job of the testing workflow.

Solution

Add the missing step to the test job of the testing workflow.

How did you test this change?

Verified that the test job running on this PR executes the step.

@caugner caugner requested a review from a team as a code owner February 6, 2024 11:54
Copy link
Contributor Author

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-approval, since #10456 was approved.

@caugner caugner merged commit 5a0cec4 into main Feb 6, 2024
12 checks passed
@caugner caugner deleted the fixup-vscode-ripgrep-bin-cache branch February 6, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant