Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): resolve http-cache-semantics to >=4.1.1 #10462

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Feb 6, 2024

Summary

Bumps the indirect dependency http-cache-semantics by defining a resolution >=4.1.1, since imagemin-{gifsicle,mozjpeg,pngquant} depend on [email protected] via [email protected].

Note: The only breaking change of http-cache-semantics v4 is the drop of Node.js 4 support, see: kornelski/http-cache-semantics@v3.8.1...v4.0.0

How did you test this change?

See checks.

The only breaking change of v4 is the drop of Node.js 4 support, see:
kornelski/http-cache-semantics@v3.8.1...v4.0.0
@caugner caugner requested a review from mdn-bot as a code owner February 6, 2024 10:36
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Feb 6, 2024
Copy link
Contributor Author

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-approval.

@caugner caugner changed the title chore(deps): resolve http-cache-semantics to 4.1.1 chore(deps): resolve http-cache-semantics to >=4.1.1 Feb 6, 2024
@caugner caugner merged commit 85f7368 into main Feb 6, 2024
15 checks passed
@caugner caugner deleted the deps-http-cache-semantics-4.1.1 branch February 6, 2024 10:41
@caugner
Copy link
Contributor Author

caugner commented Feb 6, 2024

FWIW An alternative would have been to bump cacheable-request to ^3.0.0, because its only breaking change seems to have been the drop of Node 4/6 support: jaredwray/cacheable@v2.1.4...v3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant