From 2e73956990a455ce9e845d443629367dfab5fdcd Mon Sep 17 00:00:00 2001 From: A1lo Date: Fri, 10 Nov 2023 21:19:14 +0800 Subject: [PATCH 1/2] chore(ci/pr-check_redirects): remove path filter to always run the required test --- .github/workflows/pr-check_redirects.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/pr-check_redirects.yml b/.github/workflows/pr-check_redirects.yml index 090e956c7e5c97..3138e2e4272685 100644 --- a/.github/workflows/pr-check_redirects.yml +++ b/.github/workflows/pr-check_redirects.yml @@ -4,10 +4,6 @@ on: pull_request: branches: - main - paths: - - .nvmrc - - files/** - - .github/workflows/pr-check_redirects.yml jobs: check_redirects: From 83f894dc5bcd0826a16014162fe6aee10a81b6a5 Mon Sep 17 00:00:00 2001 From: Allo Date: Sun, 12 Nov 2023 11:18:25 +0800 Subject: [PATCH 2/2] add path filter --- .github/workflows/pr-check_redirects.yml | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/.github/workflows/pr-check_redirects.yml b/.github/workflows/pr-check_redirects.yml index 3138e2e4272685..e7d8a06664de92 100644 --- a/.github/workflows/pr-check_redirects.yml +++ b/.github/workflows/pr-check_redirects.yml @@ -14,12 +14,27 @@ jobs: steps: - uses: actions/checkout@v4 + # This is a "required" workflow so path filtering can not be used: + # https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks + # We have to rely on a custom filtering mechanism to run the checks only if required files are modified. + - uses: dorny/paths-filter@v2 + name: See if any file needs checking + id: filter + with: + filters: | + required_files: + - ".nvmrc" + - "files/**" + - ".github/workflows/pr-check_redirects.yml" + - uses: actions/checkout@v4 + if: steps.filter.outputs.required_files == 'true' with: repository: mdn/content path: mdn/content - name: Setup Node.js environment + if: steps.filter.outputs.required_files == 'true' uses: actions/setup-node@v4 with: node-version-file: ".nvmrc" @@ -27,6 +42,7 @@ jobs: cache-dependency-path: mdn/content/yarn.lock - name: Install all yarn packages + if: steps.filter.outputs.required_files == 'true' working-directory: ${{ github.workspace }}/mdn/content run: | yarn --frozen-lockfile @@ -35,6 +51,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - name: Check redirects file(s) + if: steps.filter.outputs.required_files == 'true' env: CONTENT_ROOT: ${{ github.workspace }}/mdn/content/files CONTENT_TRANSLATED_ROOT: ${{ github.workspace }}/files