From 53dbdb2bad2861d5f5b5858a36d8e35c583c8c6e Mon Sep 17 00:00:00 2001
From: A1lo <yin199909@aliyun.com>
Date: Fri, 17 Nov 2023 18:09:49 +0800
Subject: [PATCH] chore(ci/pr-check_redirects): remove path filter to always
 run the required test (#16903)

---
 .github/workflows/pr-check_redirects.yml | 21 +++++++++++++++++----
 1 file changed, 17 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/pr-check_redirects.yml b/.github/workflows/pr-check_redirects.yml
index 090e956c7e5c97..e7d8a06664de92 100644
--- a/.github/workflows/pr-check_redirects.yml
+++ b/.github/workflows/pr-check_redirects.yml
@@ -4,10 +4,6 @@ on:
   pull_request:
     branches:
       - main
-    paths:
-      - .nvmrc
-      - files/**
-      - .github/workflows/pr-check_redirects.yml
 
 jobs:
   check_redirects:
@@ -18,12 +14,27 @@ jobs:
     steps:
       - uses: actions/checkout@v4
 
+      # This is a "required" workflow so path filtering can not be used:
+      # https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks
+      # We have to rely on a custom filtering mechanism to run the checks only if required files are modified.
+      - uses: dorny/paths-filter@v2
+        name: See if any file needs checking
+        id: filter
+        with:
+          filters: |
+            required_files:
+              - ".nvmrc"
+              - "files/**"
+              - ".github/workflows/pr-check_redirects.yml"
+
       - uses: actions/checkout@v4
+        if: steps.filter.outputs.required_files == 'true'
         with:
           repository: mdn/content
           path: mdn/content
 
       - name: Setup Node.js environment
+        if: steps.filter.outputs.required_files == 'true'
         uses: actions/setup-node@v4
         with:
           node-version-file: ".nvmrc"
@@ -31,6 +42,7 @@ jobs:
           cache-dependency-path: mdn/content/yarn.lock
 
       - name: Install all yarn packages
+        if: steps.filter.outputs.required_files == 'true'
         working-directory: ${{ github.workspace }}/mdn/content
         run: |
           yarn --frozen-lockfile
@@ -39,6 +51,7 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Check redirects file(s)
+        if: steps.filter.outputs.required_files == 'true'
         env:
           CONTENT_ROOT: ${{ github.workspace }}/mdn/content/files
           CONTENT_TRANSLATED_ROOT: ${{ github.workspace }}/files