Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content bug: many syntax snippets incorrectly use static Interface.member style #3487

Closed
foolip opened this issue Mar 25, 2021 · 2 comments
Closed
Labels
Content:WebAPI Web API docs

Comments

@foolip
Copy link
Contributor

foolip commented Mar 25, 2021

What page(s) did you find the problem on?

I found and fixed a number of these in #3452.

What is the problem?

The syntax snippets have been copied from the page title, and can be something like var sinkId = HTMLMediaElement.sinkId. This doesn't work, because sinkId is not a static member of HTMLMediaElement, it's on the prototype.

What did you expect to see?

Examples like this need to be var sinkId = mediaElement.sinkId or similar.

Did you test this? If so, how?

I searched using git grep -E '= [A-Z][A-Za-z0-9]+\.'. Many legitimate cases like Math.* and JSON.* show up, but there are still many incorrect cases left.

@foolip foolip added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Mar 25, 2021
@foolip
Copy link
Contributor Author

foolip commented Mar 25, 2021

@Rumyra Rumyra added the Content:WebAPI Web API docs label May 19, 2021
@github-actions github-actions bot added the idle label Dec 9, 2021
@sideshowbarker sideshowbarker removed idle needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Dec 10, 2021
@sideshowbarker
Copy link
Member

This is now being tracked in https://github.com/mdn/content/discussions/5121

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

No branches or pull requests

3 participants