Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple elements on :nth-col and :nth-last-col are missing or incorrect #23365

Closed
yarusome opened this issue Jan 4, 2023 · 6 comments · Fixed by #23409
Closed

Multiple elements on :nth-col and :nth-last-col are missing or incorrect #23365

yarusome opened this issue Jan 4, 2023 · 6 comments · Fixed by #23409
Assignees
Labels
Content:CSS Cascading Style Sheets docs help wanted If you know something about this topic, we would love your help!

Comments

@yarusome
Copy link
Contributor

yarusome commented Jan 4, 2023

MDN URL

https://developer.mozilla.org/en-US/docs/Web/CSS/:nth-col

What specific section or headline is this issue about?

Title, specifications, bowser compatibility

What information was incorrect, unhelpful, or incomplete?

  1. The two pseudo-classes are named as :nth-col and :nth-last-col both in the titles and in the left navigation column, inconsistent with :nth-child(), :nth-last-child(), :nth-of-type(), :nth-last-of-type().
  2. No experiment icon shows on the left of the two pseudo-classes in the navigation column.
  3. No specification links.
  4. No BCD data.

What did you expect to see?

  1. The two pseudo-classes be named as :nth-col() and :nth-last-col() both in the titles and in the left navigation column.
  2. Experiment icons on the left of the two pseudo-classes in the navigation column.
  3. Specification links pointing to Selector Level 4 #the-nth-col-pseudo and Selector Level 4 #nth-last-col-pseudo.
  4. BCD data on the two pseudo-classes.

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

No response

@yarusome yarusome added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jan 4, 2023
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Jan 4, 2023
@sideshowbarker sideshowbarker added help wanted If you know something about this topic, we would love your help! and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Jan 4, 2023
@KianYang-Lee
Copy link
Contributor

KianYang-Lee commented Jan 4, 2023

Good day, @sideshowbarker I can take this issue and make relevant fixes for point 1, 2 and 3, however for point 4, when I check at https://unpkg.com/@mdn/[email protected]/data.json , there's yet to be BCD for these two selector.

Spec link for the two selecters are:

Would also like to know which file to edit in order to change the nav content, thank you.

@sideshowbarker
Copy link
Collaborator

@KianYang-Lee Yes — resolving this issue should also include updating the BCD data

@KianYang-Lee
Copy link
Contributor

Well @sideshowbarker I can help to resolve this issue if you can provide a simple guide or link on how to update the BCD data, as this is my first time doing this.

@dawei-wang
Copy link
Contributor

@KianYang-Lee
Copy link
Contributor

OK please assign me and I will work on this later today, thanks

@KianYang-Lee
Copy link
Contributor

Refering to here Data guidelines for BCD, since as of now no browser supports this feature, it should not be added into BCD (proposed in mdn/browser-compat-data#10619). So, point 2, 3 and 4 is not applicable anymore in this case as they should not be included in BCD yet. I have made a PR which should partially resolve this issue, for now at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs help wanted If you know something about this topic, we would love your help!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants