Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nodejs data for Worker #25012

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Nov 9, 2024

Summary

initially added via nodejs/node#20876, in https://nodejs.org/zh-cn/blog/release/v10.5.0, need to be enabled by --experimental-worker runtime CLI flag

exposed via module and remove the runtime CLI flag via nodejs/node#25361, in https://nodejs.org/zh-cn/blog/release/v11.7.0

see https://nodejs.org/docs/latest/api/worker_threads.html#class-worker, note that the doc has no info about the experimental status between v10.5.0 and v11.7.0, the issue fired at nodejs/node#55794

update the data for Worker, as there is already a ecmascript_modules field shows the ESM support

the data for error event is confirmed with the intial pr nodejs/node#20876

the data for messageerror event and terminate() method come from the documentation, also confirmed by release and impl pr

https://nodejs.org/zh-cn/blog/release/v12.19.0
https://nodejs.org/zh-cn/blog/release/v14.5.0
nodejs/node#33772

https://nodejs.org/zh-cn/blog/release/v12.5.0
nodejs/node#28021

Test results and supporting details

confirmed by landing PRs and release notes

also test in local node runtime:

image

image

Related issues

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 9, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review November 9, 2024 00:30
api/Worker.json Outdated Show resolved Hide resolved
@caugner caugner added the nodejs Data about Node.js label Nov 12, 2024
@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Nov 18, 2024
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Nov 18, 2024
api/Worker.json Outdated Show resolved Hide resolved
api/Worker.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the size:l [PR only] 101-1000 LoC changed label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API nodejs Data about Node.js size:l [PR only] 101-1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants