Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention flag support for irrelevant feature removal #21521

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

queengooborg
Copy link
Collaborator

This PR updates the guidelines for irrelevant feature removal to specify a feature can be removed if it's no longer available behind a flag in the latest stable browser release.

@github-actions github-actions bot added the docs Issues or pull requests regarding the documentation of this project. label Dec 7, 2023
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 But I guess this will formally be approved by the owners/peers next Tuesday.

@queengooborg
Copy link
Collaborator Author

I'd say that this can actually be merged without approval from another owner! Normally, a policy/guideline change would need another owner to approve the changes, but unlike other policies, this isn't actually changing our policy; it's just clarifying what is already inferred by our flag data removal guideline and the existing linter rules.

@queengooborg queengooborg merged commit 46eb429 into main Dec 8, 2023
8 checks passed
@queengooborg queengooborg deleted the queengooborg-patch-3 branch December 8, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues or pull requests regarding the documentation of this project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants