Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing api.PermissionStatus.name feature #13466

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

queengooborg
Copy link
Contributor

This PR is a part of a project to add missing interfaces and interface features to BCD that are from an active spec (including WICG specs) and is supported in at least one browser. This particular PR adds the missing name member of the PermissionStatus API, populating the results using data from the mdn-bcd-collector project (v4.0.0).

Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/PermissionStatus/name

Check out the collector's guide on how to review this PR.

This PR is a part of a project to add missing interfaces and interface features to BCD that are from an active spec (including WICG specs) and is supported in at least one browser.  This particular PR adds the missing `name` member of the PermissionStatus API, populating the results using data from the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v4.0.0).

Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/PermissionStatus/name

_Check out the [collector's guide on how to review this PR](https://github.com/foolip/mdn-bcd-collector#reviewing-bcd-changes)._
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 11, 2021
@foolip foolip merged commit 66ea5ba into mdn:main Nov 12, 2021
@queengooborg queengooborg deleted the api/PermissionStatus/name/additions branch November 12, 2021 10:50
@hamishwillee
Copy link
Contributor

@queengooborg This is good, but shouldn't PermissionStatus and the other items (except for name) have the experimental status set to false?

@queengooborg
Copy link
Contributor Author

Good catch! Yes, the API and all of its features (aside from name) shouldn't be labeled experimental.

@hamishwillee
Copy link
Contributor

OK, I'll PR that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants