From 19fd185c608c726497ea6a71acb78ae8382e28fc Mon Sep 17 00:00:00 2001 From: Queen Vinyl Darkscratch Date: Thu, 22 Jul 2021 15:34:45 -0700 Subject: [PATCH 1/6] Add missing features for DOMRect API This PR is a part of a project to add missing interfaces and interface features to BCD that are from an active spec (including WICG specs) and is supported in at least one browser. This particular PR adds the missing features of the DOMRect API, populating the results using data from the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v3.2.1). Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/DOMRect --- api/DOMRect.json | 198 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 198 insertions(+) diff --git a/api/DOMRect.json b/api/DOMRect.json index c9c6b342c84b42..b73ff46f07c0ed 100644 --- a/api/DOMRect.json +++ b/api/DOMRect.json @@ -225,6 +225,106 @@ } } }, + "height": { + "__compat": { + "mdn_url": "https://developer.mozilla.org/docs/Web/API/DOMRectReadOnly/height", + "spec_url": "https://drafts.fxtf.org/geometry/#dom-domrectreadonly-height", + "support": { + "chrome": { + "version_added": "61" + }, + "chrome_android": { + "version_added": "61" + }, + "edge": { + "version_added": "79" + }, + "firefox": { + "version_added": "27" + }, + "firefox_android": { + "version_added": "27" + }, + "ie": { + "version_added": false, + "notes": "Implemented on the proprietary ClientRect interface." + }, + "opera": { + "version_added": "48" + }, + "opera_android": { + "version_added": "45" + }, + "safari": { + "version_added": "10.1" + }, + "safari_ios": { + "version_added": "10.3" + }, + "samsunginternet_android": { + "version_added": "8.0" + }, + "webview_android": { + "version_added": "61" + } + }, + "status": { + "experimental": false, + "standard_track": true, + "deprecated": false + } + } + }, + "width": { + "__compat": { + "mdn_url": "https://developer.mozilla.org/docs/Web/API/DOMRectReadOnly/width", + "spec_url": "https://drafts.fxtf.org/geometry/#dom-domrectreadonly-width", + "support": { + "chrome": { + "version_added": "61" + }, + "chrome_android": { + "version_added": "61" + }, + "edge": { + "version_added": "79" + }, + "firefox": { + "version_added": "27" + }, + "firefox_android": { + "version_added": "27" + }, + "ie": { + "version_added": false, + "notes": "Implemented on the proprietary ClientRect interface." + }, + "opera": { + "version_added": "48" + }, + "opera_android": { + "version_added": "45" + }, + "safari": { + "version_added": "10.1" + }, + "safari_ios": { + "version_added": "10.3" + }, + "samsunginternet_android": { + "version_added": "8.0" + }, + "webview_android": { + "version_added": "61" + } + }, + "status": { + "experimental": false, + "standard_track": true, + "deprecated": false + } + } + }, "worker_support": { "__compat": { "description": "Available in workers", @@ -272,6 +372,104 @@ "deprecated": false } } + }, + "x": { + "__compat": { + "mdn_url": "https://developer.mozilla.org/docs/Web/API/DOMRectReadOnly/x", + "spec_url": "https://drafts.fxtf.org/geometry/#dom-domrectreadonly-x", + "support": { + "chrome": { + "version_added": "61" + }, + "chrome_android": { + "version_added": "61" + }, + "edge": { + "version_added": "79" + }, + "firefox": { + "version_added": "31" + }, + "firefox_android": { + "version_added": "31" + }, + "ie": { + "version_added": false + }, + "opera": { + "version_added": "48" + }, + "opera_android": { + "version_added": "45" + }, + "safari": { + "version_added": "10.1" + }, + "safari_ios": { + "version_added": "10.3" + }, + "samsunginternet_android": { + "version_added": "8.0" + }, + "webview_android": { + "version_added": "61" + } + }, + "status": { + "experimental": false, + "standard_track": true, + "deprecated": false + } + } + }, + "y": { + "__compat": { + "mdn_url": "https://developer.mozilla.org/docs/Web/API/DOMRectReadOnly/y", + "spec_url": "https://drafts.fxtf.org/geometry/#dom-domrectreadonly-y", + "support": { + "chrome": { + "version_added": "61" + }, + "chrome_android": { + "version_added": "61" + }, + "edge": { + "version_added": "79" + }, + "firefox": { + "version_added": "31" + }, + "firefox_android": { + "version_added": "31" + }, + "ie": { + "version_added": false + }, + "opera": { + "version_added": "48" + }, + "opera_android": { + "version_added": "45" + }, + "safari": { + "version_added": "10.1" + }, + "safari_ios": { + "version_added": "10.3" + }, + "samsunginternet_android": { + "version_added": "8.0" + }, + "webview_android": { + "version_added": "61" + } + }, + "status": { + "experimental": false, + "standard_track": true, + "deprecated": false + } + } } } } From 487d560d3bdf0ff61b436e3dcbdf99cefc99cc00 Mon Sep 17 00:00:00 2001 From: Queen Vinyl Darkscratch Date: Thu, 22 Jul 2021 16:40:27 -0700 Subject: [PATCH 2/6] Remove 404 URLs --- api/DOMRect.json | 4 ---- 1 file changed, 4 deletions(-) diff --git a/api/DOMRect.json b/api/DOMRect.json index b73ff46f07c0ed..5d6843c35fd894 100644 --- a/api/DOMRect.json +++ b/api/DOMRect.json @@ -227,7 +227,6 @@ }, "height": { "__compat": { - "mdn_url": "https://developer.mozilla.org/docs/Web/API/DOMRectReadOnly/height", "spec_url": "https://drafts.fxtf.org/geometry/#dom-domrectreadonly-height", "support": { "chrome": { @@ -277,7 +276,6 @@ }, "width": { "__compat": { - "mdn_url": "https://developer.mozilla.org/docs/Web/API/DOMRectReadOnly/width", "spec_url": "https://drafts.fxtf.org/geometry/#dom-domrectreadonly-width", "support": { "chrome": { @@ -375,7 +373,6 @@ }, "x": { "__compat": { - "mdn_url": "https://developer.mozilla.org/docs/Web/API/DOMRectReadOnly/x", "spec_url": "https://drafts.fxtf.org/geometry/#dom-domrectreadonly-x", "support": { "chrome": { @@ -424,7 +421,6 @@ }, "y": { "__compat": { - "mdn_url": "https://developer.mozilla.org/docs/Web/API/DOMRectReadOnly/y", "spec_url": "https://drafts.fxtf.org/geometry/#dom-domrectreadonly-y", "support": { "chrome": { From 75d0eceb5fc2043cd3ec7525ecddf970f996a107 Mon Sep 17 00:00:00 2001 From: Queen Vinyl Darkscratch Date: Fri, 23 Jul 2021 08:58:29 -0700 Subject: [PATCH 3/6] Fix spec URLs from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Philip Jägenstedt --- api/DOMRect.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/api/DOMRect.json b/api/DOMRect.json index 5d6843c35fd894..d465bd5f7e1d0b 100644 --- a/api/DOMRect.json +++ b/api/DOMRect.json @@ -227,7 +227,7 @@ }, "height": { "__compat": { - "spec_url": "https://drafts.fxtf.org/geometry/#dom-domrectreadonly-height", + "spec_url": "https://drafts.fxtf.org/geometry/#dom-domrect-height", "support": { "chrome": { "version_added": "61" @@ -276,7 +276,7 @@ }, "width": { "__compat": { - "spec_url": "https://drafts.fxtf.org/geometry/#dom-domrectreadonly-width", + "spec_url": "https://drafts.fxtf.org/geometry/#dom-domrect-width", "support": { "chrome": { "version_added": "61" @@ -373,7 +373,7 @@ }, "x": { "__compat": { - "spec_url": "https://drafts.fxtf.org/geometry/#dom-domrectreadonly-x", + "spec_url": "https://drafts.fxtf.org/geometry/#dom-domrect-x", "support": { "chrome": { "version_added": "61" @@ -421,7 +421,7 @@ }, "y": { "__compat": { - "spec_url": "https://drafts.fxtf.org/geometry/#dom-domrectreadonly-y", + "spec_url": "https://drafts.fxtf.org/geometry/#dom-domrect-y", "support": { "chrome": { "version_added": "61" From aa51d7bad2fac31411d873a64dc443ec55bc4123 Mon Sep 17 00:00:00 2001 From: Queen Vinyl Darkscratch Date: Fri, 23 Jul 2021 09:11:42 -0700 Subject: [PATCH 4/6] Update version numbers --- api/DOMRect.json | 82 +++++++++++++++++++++++------------------------- 1 file changed, 40 insertions(+), 42 deletions(-) diff --git a/api/DOMRect.json b/api/DOMRect.json index d465bd5f7e1d0b..5acf9c72f9760f 100644 --- a/api/DOMRect.json +++ b/api/DOMRect.json @@ -230,41 +230,40 @@ "spec_url": "https://drafts.fxtf.org/geometry/#dom-domrect-height", "support": { "chrome": { - "version_added": "61" + "version_added": "2" }, "chrome_android": { - "version_added": "61" + "version_added": "18" }, "edge": { - "version_added": "79" + "version_added": "12" }, "firefox": { - "version_added": "27" + "version_added": "3" }, "firefox_android": { - "version_added": "27" + "version_added": "4" }, "ie": { - "version_added": false, - "notes": "Implemented on the proprietary ClientRect interface." + "version_added": "4" }, "opera": { - "version_added": "48" + "version_added": "≤12.1" }, "opera_android": { - "version_added": "45" + "version_added": "≤12.1" }, "safari": { - "version_added": "10.1" + "version_added": "4" }, "safari_ios": { - "version_added": "10.3" + "version_added": "3.2" }, "samsunginternet_android": { "version_added": "8.0" }, "webview_android": { - "version_added": "61" + "version_added": "≤37" } }, "status": { @@ -279,41 +278,40 @@ "spec_url": "https://drafts.fxtf.org/geometry/#dom-domrect-width", "support": { "chrome": { - "version_added": "61" + "version_added": "2" }, "chrome_android": { - "version_added": "61" + "version_added": "18" }, "edge": { - "version_added": "79" + "version_added": "12" }, "firefox": { - "version_added": "27" + "version_added": "3" }, "firefox_android": { - "version_added": "27" + "version_added": "4" }, "ie": { - "version_added": false, - "notes": "Implemented on the proprietary ClientRect interface." + "version_added": "4" }, "opera": { - "version_added": "48" + "version_added": "≤12.1" }, "opera_android": { - "version_added": "45" + "version_added": "≤12.1" }, "safari": { - "version_added": "10.1" + "version_added": "4" }, "safari_ios": { - "version_added": "10.3" + "version_added": "3.2" }, "samsunginternet_android": { "version_added": "8.0" }, "webview_android": { - "version_added": "61" + "version_added": "≤37" } }, "status": { @@ -376,13 +374,13 @@ "spec_url": "https://drafts.fxtf.org/geometry/#dom-domrect-x", "support": { "chrome": { - "version_added": "61" + "version_added": "2" }, "chrome_android": { - "version_added": "61" + "version_added": "18" }, "edge": { - "version_added": "79" + "version_added": "12" }, "firefox": { "version_added": "31" @@ -391,25 +389,25 @@ "version_added": "31" }, "ie": { - "version_added": false + "version_added": "4" }, "opera": { - "version_added": "48" + "version_added": "≤12.1" }, "opera_android": { - "version_added": "45" + "version_added": "≤12.1" }, "safari": { - "version_added": "10.1" + "version_added": "4" }, "safari_ios": { - "version_added": "10.3" + "version_added": "3.2" }, "samsunginternet_android": { "version_added": "8.0" }, "webview_android": { - "version_added": "61" + "version_added": "≤37" } }, "status": { @@ -424,13 +422,13 @@ "spec_url": "https://drafts.fxtf.org/geometry/#dom-domrect-y", "support": { "chrome": { - "version_added": "61" + "version_added": "2" }, "chrome_android": { - "version_added": "61" + "version_added": "18" }, "edge": { - "version_added": "79" + "version_added": "12" }, "firefox": { "version_added": "31" @@ -439,25 +437,25 @@ "version_added": "31" }, "ie": { - "version_added": false + "version_added": "4" }, "opera": { - "version_added": "48" + "version_added": "≤12.1" }, "opera_android": { - "version_added": "45" + "version_added": "≤12.1" }, "safari": { - "version_added": "10.1" + "version_added": "4" }, "safari_ios": { - "version_added": "10.3" + "version_added": "3.2" }, "samsunginternet_android": { "version_added": "8.0" }, "webview_android": { - "version_added": "61" + "version_added": "≤37" } }, "status": { From 287fd4dfe652c5ff3dba33dd75b460b509689e23 Mon Sep 17 00:00:00 2001 From: Queen Vinyl Darkscratch Date: Tue, 3 Aug 2021 03:49:25 -0700 Subject: [PATCH 5/6] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Philip Jägenstedt --- api/DOMRect.json | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/api/DOMRect.json b/api/DOMRect.json index 5acf9c72f9760f..440b5c308e6c95 100644 --- a/api/DOMRect.json +++ b/api/DOMRect.json @@ -248,10 +248,10 @@ "version_added": "4" }, "opera": { - "version_added": "≤12.1" + "version_added": "9.5" }, "opera_android": { - "version_added": "≤12.1" + "version_added": "10.1" }, "safari": { "version_added": "4" @@ -260,10 +260,10 @@ "version_added": "3.2" }, "samsunginternet_android": { - "version_added": "8.0" + "version_added": "1.0" }, "webview_android": { - "version_added": "≤37" + "version_added": "2" } }, "status": { @@ -296,10 +296,10 @@ "version_added": "4" }, "opera": { - "version_added": "≤12.1" + "version_added": "9.5" }, "opera_android": { - "version_added": "≤12.1" + "version_added": "10.1" }, "safari": { "version_added": "4" @@ -308,10 +308,10 @@ "version_added": "3.2" }, "samsunginternet_android": { - "version_added": "8.0" + "version_added": "1.0" }, "webview_android": { - "version_added": "≤37" + "version_added": "2" } }, "status": { From 911b933ab7723890fb21d77aa4b8512f8ce150ac Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Philip=20J=C3=A4genstedt?= Date: Tue, 10 Aug 2021 09:46:35 +0200 Subject: [PATCH 6/6] Apply suggestions from code review --- api/DOMRect.json | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/api/DOMRect.json b/api/DOMRect.json index 440b5c308e6c95..76d34345621513 100644 --- a/api/DOMRect.json +++ b/api/DOMRect.json @@ -374,13 +374,13 @@ "spec_url": "https://drafts.fxtf.org/geometry/#dom-domrect-x", "support": { "chrome": { - "version_added": "2" + "version_added": "61" }, "chrome_android": { - "version_added": "18" + "version_added": "61" }, "edge": { - "version_added": "12" + "version_added": "79" }, "firefox": { "version_added": "31" @@ -389,25 +389,25 @@ "version_added": "31" }, "ie": { - "version_added": "4" + "version_added": false }, "opera": { - "version_added": "≤12.1" + "version_added": "48" }, "opera_android": { - "version_added": "≤12.1" + "version_added": "45" }, "safari": { - "version_added": "4" + "version_added": "10.1" }, "safari_ios": { - "version_added": "3.2" + "version_added": "10.3" }, "samsunginternet_android": { "version_added": "8.0" }, "webview_android": { - "version_added": "≤37" + "version_added": "61" } }, "status": { @@ -422,13 +422,13 @@ "spec_url": "https://drafts.fxtf.org/geometry/#dom-domrect-y", "support": { "chrome": { - "version_added": "2" + "version_added": "61" }, "chrome_android": { - "version_added": "18" + "version_added": "61" }, "edge": { - "version_added": "12" + "version_added": "79" }, "firefox": { "version_added": "31" @@ -437,25 +437,25 @@ "version_added": "31" }, "ie": { - "version_added": "4" + "version_added": false }, "opera": { - "version_added": "≤12.1" + "version_added": "48" }, "opera_android": { - "version_added": "≤12.1" + "version_added": "45" }, "safari": { - "version_added": "4" + "version_added": "10.1" }, "safari_ios": { - "version_added": "3.2" + "version_added": "10.3" }, "samsunginternet_android": { "version_added": "8.0" }, "webview_android": { - "version_added": "≤37" + "version_added": "61" } }, "status": {