Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add range for Safari ≤3? #6807

Closed
queengooborg opened this issue Oct 3, 2020 · 5 comments · Fixed by #6915
Closed

Add range for Safari ≤3? #6807

queengooborg opened this issue Oct 3, 2020 · 5 comments · Fixed by #6915
Labels
linter Issues or pull requests regarding the tests / linter of the JSON files. question Issues where a question or problem is stated and a discussion is held to gather opinions.

Comments

@queengooborg
Copy link
Contributor

Considering how challenging it is to test Safari 1-2, I'm thinking we should add a range for Safari 3 and lower?

@queengooborg queengooborg added question Issues where a question or problem is stated and a discussion is held to gather opinions. linter Issues or pull requests regarding the tests / linter of the JSON files. labels Oct 3, 2020
@foolip
Copy link
Contributor

foolip commented Oct 7, 2020

@vinyldarkscratch you've recently been sending PRs setting Safari versions <3, did you work out a way to test Safari 1-2?

In any case, I certainly supporting adding ranges where it's very hard to test older versions, for whatever reason.

@queengooborg
Copy link
Contributor Author

I have a way to test Safari 1-2, yes, but it's very challenging. To put it simply, I have a Windows XP virtual machine that runs a PowerPC emulator, with an unreliable network bridge between them (before the network bridge, I typed out the tests manually.) Some days, I simply cannot get the VM to function properly at all...

@foolip
Copy link
Contributor

foolip commented Oct 7, 2020

I see, that doesn't sounds reasonable to just distinguish between things introduced in 2003 vs. 2007, both are in the distant past now.

How about Safari 3, how does one test that? The oldest available on BrowserStack is now Safari 4.

@queengooborg
Copy link
Contributor Author

queengooborg commented Oct 7, 2020

I have a collection of VMs for browser versions older than what is in SauceLabs (though I should probably add Edge 13-14 since BrowserStack does not have them), of which are available here: https://drive.google.com/drive/folders/1w6nVUMD5MwkoevzuhCDuDpbxyk3ywCRY This collection includes Safari 3, of which was the first version supported on Windows, thus eliminating the need for emulating it on PowerPC (which is a big part of why it's so challenging to test Safari 1-2).

@foolip
Copy link
Contributor

foolip commented Oct 7, 2020

Aha, Safari for Windows. I would expect there are some differences between that and OS X, so testing on OS X on as old versions of Safari as possible would be good still.

Anyway, ≤3 seems reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter Issues or pull requests regarding the tests / linter of the JSON files. question Issues where a question or problem is stated and a discussion is held to gather opinions.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants