Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter: enforce .editorconfig? #5362

Closed
queengooborg opened this issue Dec 22, 2019 · 2 comments
Closed

Linter: enforce .editorconfig? #5362

queengooborg opened this issue Dec 22, 2019 · 2 comments
Labels
linter 🏡 Issues or pull requests regarding the tests / linter of the JSON files.

Comments

@queengooborg
Copy link
Collaborator

An .editorconfig file is quite helpful in ensuring all of the files follow the same EOLs, indentations, etc. A good number of modern editors support natively, although there's also a number that would require a plugin, or don't support it at all. I'm thinking that we should add onto our formatting test and check the .editorconfig file as well. It looks like there's an NPM package that will help us already, and I'm happy to tackle this one!

@queengooborg queengooborg added the linter 🏡 Issues or pull requests regarding the tests / linter of the JSON files. label Dec 22, 2019
@queengooborg
Copy link
Collaborator Author

Closing this issue because the package doesn't enforce the .editorconfig, and I can't find anything that does. We have Prettier as well now, so that should take care of formatting.

@queengooborg
Copy link
Collaborator Author

Prettier formatting has been good enough it seems, so I'm going to go ahead and close this issue.

@queengooborg queengooborg closed this as not planned Won't fix, can't repro, duplicate, stale Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter 🏡 Issues or pull requests regarding the tests / linter of the JSON files.
Projects
None yet
Development

No branches or pull requests

1 participant