Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: cleanup data in notes #5190

Closed
queengooborg opened this issue Nov 21, 2019 · 3 comments
Closed

Chore: cleanup data in notes #5190

queengooborg opened this issue Nov 21, 2019 · 3 comments
Labels
bulk_update An update to a mass amount of data, or scripts/linters related to such changes

Comments

@queengooborg
Copy link
Collaborator

queengooborg commented Nov 21, 2019

As I was reviewing the Samsung Internet mirroring PRs, I noticed various points of data expressed in the notes that had significant information regarding the support in the browser. For example, in Chrome Android, there was support from the initial release, but then there was a note indicating how it's only supported in Windows and Linux. Obviously, this should make Chrome Android support false instead.

When we have some time, we should skim through the notes and update their data, removing redundant information and overall cleaning up.

(Speaking of, do we want to keep our "This value is recognized, but has no effect." notes?
We had a discussion about this somewhere, but I can't remember what the outcome was.)

@queengooborg queengooborg added the bulk_update An update to a mass amount of data, or scripts/linters related to such changes label Nov 21, 2019
@ddbeck
Copy link
Collaborator

ddbeck commented Nov 21, 2019

(Speaking of, do we want to keep our "This value is recognized, but has no effect." notes?
We had a discussion about this somewhere, but I can't remember what the outcome was.)

I think this was the end of that discussion: #3904 (comment). The short answer is yes, keep the notes. The discussion was more about how it interacted with "partial_implementation": if you have a real version number for such a (mis-)feature, set "partial_implementation": true and keep the note. If you don't have a real version number, keep the note and set "version_added": false. In other words, it's an editorial decision that privileges version number accuracy over the correctness of the "partial_implementation" flag.

I ought to write this up in the data policies doc.

@ddbeck
Copy link
Collaborator

ddbeck commented Nov 21, 2019

I ought to write this up in the data policies doc.

Oh wait I already did, though I didn't address the notes question specifically.

@github-actions github-actions bot added the idle Issues and pull requests with no recent activity label May 25, 2022
@queengooborg queengooborg pinned this issue Jul 11, 2023
@queengooborg queengooborg removed the idle Issues and pull requests with no recent activity label Jul 11, 2023
@Elchi3
Copy link
Member

Elchi3 commented Aug 10, 2023

I'm closing this stalled issue. I think the introduction of "mirror" cleaned out a lot of weird notes.

@Elchi3 Elchi3 closed this as completed Aug 10, 2023
@Elchi3 Elchi3 unpinned this issue Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bulk_update An update to a mass amount of data, or scripts/linters related to such changes
Projects
None yet
Development

No branches or pull requests

3 participants