Allow hidden CSS src in tabbed examples #989
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when we want to add new font to single HTML interactive example, following steps must be taken:
@font-face
toshadow-fonts.css
in BOB repoThis PR is meant to simplify this process, but allowing custom fonts to live only in interactive-examples repo and assign them to individual examples without showing
@font-face
to the user. It does that by introducingcssHiddenSrc
property inmeta.json
in tabbed examples. Now process of adding new font will look like this:@font-face
anywhere in interactive-examples repo, but preferably near fontcssHiddenSrc
property tometa.json
of an example, containing path to CSS.Another benefit of this solution, is that
@font-face
will be added only to examples that actually use them, while nowshadow-fonts.css
has to be downloaded for every example.If this gets merged, I will add CSS files with individual fonts to interactive-examples repo, so
shadow-fonts.css
can be completely removed from here, along with the fonts.Fixes #822