Update CodeMirror to v6 & drop Browserify #907
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades CodeMirror to version 6, which seems to be written from scratch. New appearance is pretty much the same, except for some minor differences:
OLD:
NEW:
OLD
NEW:
OLD:
NEW:
Pretty much all of those changes would require rewritting parser and then maintaining it on BOB repo. Instead I will create PRs in Code Mirror and maybe they will be accepted.
browserify & esmify dependencies are dropped. Please take a look if this code should be removed from webpack.config:
I have made whole CodeMirror code be in codemirror.js & codemirror.css.
When #888 is merged, I can make CodeMirror support for it too.
Fixes #851
I am also pretty sure that this PR will fix issue with gutters sometimes collapsing.