Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hover background color to editor tabs (with transitions) #865

Merged
merged 2 commits into from
Aug 31, 2022

Conversation

queengooborg
Copy link
Collaborator

This PR adds a background color to editor tabs that are both being hovered over now and are selected. This should help better show the interactability of the tabs.

@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@caugner
Copy link
Contributor

caugner commented Aug 31, 2022

Would you have before/after screenshots to attach in the PR description? 🙏

@caugner caugner added the ux label Aug 31, 2022
@queengooborg
Copy link
Collaborator Author

Sure thing -- let's see if GitHub will let me upload screenshots again!

Before:
Screen Shot 2022-08-31 at 08 40 22

After:
Screen Shot 2022-08-31 at 08 41 15
(Hovering over "CSS")
Screen Shot 2022-08-31 at 08 41 24

Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's a clear UX improvement.

@queengooborg queengooborg merged commit ae46756 into main Aug 31, 2022
@queengooborg queengooborg deleted the tab-styling branch August 31, 2022 23:52
@queengooborg queengooborg mentioned this pull request Sep 8, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants