Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): pin Node.js to v18.17 + use .nvmrc from interactive-examples #1625

Merged
merged 3 commits into from
Dec 21, 2023
Merged

fix(deps): pin Node.js to v18.17 + use .nvmrc from interactive-examples #1625

merged 3 commits into from
Dec 21, 2023

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Dec 21, 2023

Our tests fail with later minor versions.

@caugner caugner requested a review from a team as a code owner December 21, 2023 18:01
@caugner caugner changed the title fix(deps): pin Node.js to v18.17 fix(deps): pin Node.js to v18.17 + use .nvmrc from interactive-examples Dec 21, 2023
caugner
caugner commented Dec 21, 2023
View reviewed changes
Copy link
Contributor Author

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-approval, because the change is trivial and only affects our tests.

@caugner caugner merged commit 968ae6f into main Dec 21, 2023
7 checks passed
@caugner caugner deleted the pin-node-to-18.17 branch December 21, 2023 18:14
@github-actions github-actions bot mentioned this pull request Dec 21, 2023
Closed
@github-actions github-actions bot mentioned this pull request Jan 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@caugner