feat(meta): Allow cssHiddenSrc to be an array
#1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has merge conflicts that must be resolved before it can be merged. |
1 similar comment
|
This pull request has merge conflicts that must be resolved before it can be merged. |
NiedziolkaMichal
force-pushed
the
improve-hidden-css
branch
from
7e08407
to
5bf884b
Compare
|
This pull request has merge conflicts that must be resolved before it can be merged. |
2 similar comments
|
This pull request has merge conflicts that must be resolved before it can be merged. |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
queengooborg
approved these changes
Jun 9, 2023
|
Looks like there's some CI failures (I hope they weren't caused by my attempts to resolve merge conflicts), would you be down to look into it? I'll happily merge this PR shortly once CI passes! |
NiedziolkaMichal
force-pushed
the
improve-hidden-css
branch
from
9a38a3c
to
96d687d
Compare
|
@queengooborg Done :) |
queengooborg
approved these changes
Jun 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows
cssHiddenSrcto be not just a single path to a CSS, but an array of paths too. It will be useful in the interactive example ofcaption, which uses 2 different font families because I can place@font-faceof those families in different files.