Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double border in WAT examples #1004

Merged
merged 3 commits into from
Jan 19, 2023
Merged

Conversation

NiedziolkaMichal
Copy link
Member

@NiedziolkaMichal NiedziolkaMichal commented Nov 27, 2022

Problem

Currently yari places grey border around BOB iframe, with exception of JS examples, in which following CSS rule is applied:

.interactive.is-js-height, .interactive.is-shorter-height, .interactive.is-taller-height {
    border: 0;
}

This generally works ok, except for WAT examples, in which double border is applied:
image
Here is JS for comparison:
image

Solution

This PR adds grey border to interactive examples, so it can be fully removed from YARI. Examples will look exactly the same way, except for WAT, in which there will be a single border instead of two.

If this gets deployed, temporarily every BOB example except for JS will have 2 borders, because old border will be still applied by YARI. It will be simple CSS change, so it's ok if I make PR in there after deployment of BOB or shortly before it?

This PR depends on #1003, which should be merged first

@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants