Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Loki connection optional #64

Open
evansteelepdx opened this issue Apr 14, 2022 · 0 comments
Open

Make Loki connection optional #64

evansteelepdx opened this issue Apr 14, 2022 · 0 comments

Comments

@evansteelepdx
Copy link
Contributor

Currently the Loki connection details are required as part of the startup process. Runtime errors can occur if

  • The loki object in settings.json is not populated with all required keys
  • The loki endpoint does not return a valid result in the query_loki method

Consider adding a check in the initialize function to verify that the keys in the loki object are populated. We'd also want to ensure that the default settings.json file is populated with the Loki configuration object to avoid the read errors when the settings file is read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant