Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update technical metadata #4

Closed
keunwoochoi opened this issue May 24, 2017 · 7 comments
Closed

update technical metadata #4

keunwoochoi opened this issue May 24, 2017 · 7 comments

Comments

@keunwoochoi
Copy link

keunwoochoi commented May 24, 2017

As title says. Probably it's not valid?

@tae-jun
Copy link

tae-jun commented May 24, 2017

👍 In my case, it's only 1.8KB

@mdeff
Copy link
Owner

mdeff commented May 24, 2017

Indeed. Looks like the clipping failed. I have:

  • fma_full/133/133297.mp3, 4546530 bytes, sha1 d6a6aa0d0a4264e7679aaca3c3cc4c67127143b7
  • fma_large/133/133297.mp3, 1752 bytes, sha1 19c8a6a03db7df5768cc0a424344cb2441875cb0

@mdeff
Copy link
Owner

mdeff commented May 24, 2017

Found the problem. The metadata, scraped from the FMA API, claims the song is 600 seconds long, while ffmpeg -i 133297.mp3 -f null - tells us it's about 01:53.56. The trim_audio() function in creation.py is clipping 30 seconds in the middle of the song, that is from 285s to 315s for this particular file. But that is out of the song, which is 114s long.

It's not the first time I see an error in the reported song length. The solution is to extract the duration from the file with ffmpeg and update the metadata. I should do that at some point.

@tae-jun
Copy link

tae-jun commented May 24, 2017

@mdeff You are the best! 👍

@mdeff
Copy link
Owner

mdeff commented May 24, 2017

Haha thanks @tae-jun :)

While at this, we should collect the following technical metadata to be included in tracks.csv:

  • Bit rate
  • Number of channels
  • Sample rate
  • Number of samples
  • (Duration is then a function of the above two)

I'll probably do that for the final release. If somebody wants​ to help, you're welcome. :)

@mdeff mdeff changed the title 133297.mp3 is 2KB Erroneous track durations (133297.mp3 is 2KB) May 29, 2017
@chiwanpark
Copy link

I just found same error in fma_small/108/108925.mp3.

@mdeff
Copy link
Owner

mdeff commented Jun 1, 2017

Thanks all for reporting. :) I will fix this problem for the v1 release. Don't hesitate to open issues for other problems if you find some.

@mdeff mdeff changed the title Erroneous track durations (133297.mp3 is 2KB) update technical metadata Jul 20, 2017
@mdeff mdeff closed this as completed in 3790d52 Nov 17, 2017
@mdeff mdeff reopened this Nov 17, 2017
Repository owner deleted a comment from mohitbindal10 Jan 28, 2018
@mdeff mdeff closed this as completed Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants