Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: #10 #17

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix: #10 #17

wants to merge 7 commits into from

Conversation

Bistard
Copy link

@Bistard Bistard commented Jan 20, 2024

Changes

  1. Refactor and fix: Wrap the assignment check using a helper handleAssignation.
  2. Feat: Adding AwaitExpression node selector (this fix No error triggered when await is used #10)
  3. Feat: Try to mark the first assigned variable to be reported if possible.

@Bistard Bistard mentioned this pull request Jan 20, 2024
Open
@Bistard
Copy link
Author

Bistard commented Jan 20, 2024

I haven't write the unit test yet.

@Bistard
Copy link
Author

Bistard commented Jan 20, 2024

I just noticed that wrapping into handleAssignation does not fix anything (I thought it will fix a problem but it does not).

But I am still keeping the changes since it improves readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No error triggered when await is used
1 participant
@Bistard