Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PULL REQUEST CHECKER WORKFLOW AUTOMATION 🚀 #1101

Open
amiya-cyber opened this issue Nov 7, 2024 · 4 comments
Open

PULL REQUEST CHECKER WORKFLOW AUTOMATION 🚀 #1101

amiya-cyber opened this issue Nov 7, 2024 · 4 comments
Labels
invalid This doesn't seem right pending question Further information is requested

Comments

@amiya-cyber
Copy link

Description: We need to create a GitHub Actions workflow that automates the validation of pull requests (PRs). This workflow will ensure that all PRs meet the following criteria before being merged:

PR Description Check: Every PR must have a description. If the description is missing, the PR should fail the check.

Issue Reference Check: The PR description must include an issue reference in the format Fixes #. If the PR is not addressing an existing issue, it should mention Fixes #NEW as a placeholder.

Acceptance Criteria:

A GitHub Action workflow is triggered on PR events (opened, edited).
The workflow checks the PR body for:

A non-empty description.
The presence of Fixes # or Fixes #NEW.

If the criteria are not met:
The workflow should fail and return clear error messages.

If the checks pass:
A confirmation message is outputted.

Expected Output:

  1. Error message if the PR description is missing.
  2. Error message if the issue reference is missing or incorrectly formatted.
  3. Success message when all checks are satisfied.

ASSIGN WITH LEVEL 3

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Hello amiya-cyber! Thanks for opening an issue in Ezyshop! 🚀

  • We'll get back to you as soon as possible.

  • Hope you star our Repo.

  • Join our Discord Server to collaborate and discuss further.

@mdazfar2
Copy link
Owner

mdazfar2 commented Nov 7, 2024

@amiya-cyber Tell me one thing: if a contributor creates a PR without referencing any issues, will the PR be closed automatically, or will a message be given to add issue references by github-actions? Also, tell me one more thing: can I reopen a PR that was closed without referencing any issue for merging which was closed by github-actions, especially when I create a PR from my own repo with another branch to the main branch? Then it will close automatically! Am I right?

@mdazfar2 mdazfar2 added invalid This doesn't seem right question Further information is requested pending labels Nov 7, 2024
@amiya-cyber
Copy link
Author

It will drop a msg and checks will be crossed

@mdazfar2
Copy link
Owner

mdazfar2 commented Nov 7, 2024

It will drop a msg and checks will be crossed

@amiya-cyber That's a nice suggestion. Can you make it so that when I create a PR without referencing any issue, it should be correct, and no message will be dropped, only for the owner of the repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right pending question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants