Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start phiremock instance performance #49

Closed
m1ndgr3p opened this issue Sep 7, 2021 · 2 comments
Closed

Start phiremock instance performance #49

m1ndgr3p opened this issue Sep 7, 2021 · 2 comments

Comments

@m1ndgr3p
Copy link

m1ndgr3p commented Sep 7, 2021

Hi there!

We are using this extension in our project and it's greate! thanks for your work.

If we use option wait_until_ready we are waiting for 1 second in any case. I propose to decrease this value to about 100 microseconds or make this value not hardcoded but configurable. what do you think? We have tons of functional tests and with this improvement we can speed up our ci/cd pipelines.
@mcustiel mcustiel mentioned this issue Sep 15, 2021
Merged
@mcustiel
Copy link
Owner

@m1ndgr3p Thank you very much for your nice words and sorry for the wait. Please check the PR to see if that's the feature you're expecting.

@m1ndgr3p
Copy link
Author

m1ndgr3p commented Sep 17, 2021 •
edited
Loading

yes, you understood me correctly. your changes are awesome, you have made greate job! Thanks mate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcustiel @m1ndgr3p