Fix tests so they run even with a global --color setting #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have global RSpec settings located at `~/.rspec`, and you have `--color` as one of your settings, and you try to run the `super_diff` tests locally, the integration tests, which ensure that output is printed in the correct colors and which work by spawning a new `rspec` child process for each test, will fail. I'm not exactly sure why this is happening, but we can get around this by instructing the child `rspec` process not to use the global configuration settings.
|
Works for me! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have global RSpec settings located at
~/.rspec, and you have--coloras one of your settings, and you try to run thesuper_difftests locally, the integration tests, which ensure that output is
printed in the correct colors and which work by spawning a new
rspecchild process for each test, will fail. I'm not exactly sure why this is
happening, but we can get around this by instructing the child
rspecprocess not to use the global configuration settings.