Fix compatibility with RSpec 3.10 #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmire
force-pushed
the
upgrade-rspec
branch
from
5f43f2f
to
aedc51d
Compare
mcmire
force-pushed
the
upgrade-rspec
branch
from
a2901a3
to
5c8c37f
Compare
mcmire
changed the title
mcmire
force-pushed
the
upgrade-rspec
branch
3 times, most recently
from
20045fa
to
beb1ec7
Compare
It seems that RSpec 3.10 changed the Has matcher which breaks the monkey patches that SuperDiff makes. Fix those monkey patchers and extend the Appraisals such that now we test against both RSpec < 3.10 and RSpec >= 3.10.
mcmire
force-pushed
the
upgrade-rspec
branch
from
beb1ec7
to
6f1f896
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that RSpec 3.10 changed the Has matcher which breaks the monkey
patches that SuperDiff makes. Fix those monkey patchers and extend the
Appraisals such that now we test against both RSpec < 3.10 and RSpec >=
3.10.