fix name mismatches in bitbang requests #10
Conversation
floe
changed the title
floe
changed the title
|
Thanks, I will have a look. I think the programmer code has reached its maximum level of managable complexity and probably needs a rewrite. Until then, let's keep it together with duct tape. |
| @@ -54,7 +54,7 @@ def read(port, addr, opt={}) | |||
| if !opt[:count] | |||
| reply = @drv.transfer(req) | |||
| else | |||
| req[:count] = readcount | |||
There was a problem hiding this comment.
From looking at cmsis-dap.rb, it seems that :count is the "new" way of passing this information...
There was a problem hiding this comment.
Probably we should change the bitbang driver to accept :count instead of :val
|
Swapped BTW, is there any specific reason it's written in Ruby? If a rewrite is planned anyway, maybe Python would be a more widespread option? |
|
I am thinking of using a type safe language. Regarding popularity typescript or go seem to be reasonable options. What do you think about those? On March 18, 2016 12:58:41 PM GMT+01:00, Florian Echtler [email protected] wrote:
Sent from my Android device with K-9 Mail. Please excuse my brevity. |
|
Hm, given those options, I'd prefer Go. More generally, I'd even suggest C++... |
|
Ah damn, if you swap |
|
It's all a mess, especially without type safety :/ My own mess, but still a mess. |
I'm really not a Ruby expert, so perhaps there's a better way to fix the
flush!issue (see second change inswd-bitbang.rb). But with these changes, everything works again for me with nRF51 & BusPirate.Closes #9.