-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor STM32 classes to be more like Samd21 #103
Comments
Do you also want to remove Catena-Arduino-Platform/src/lib/stm32/CatenaStm32_gk_PlatformHierarchy.cpp Lines 71 to 87 in 4ccdeff
If we remove this |
The linker is supposed to remove the unused |
I checked the linker doesn't remove the unused |
All changes are merged. |
Samd21 classes use an elaborate technique to avoid conditional compiles, based on the C compiler's ability to optimize out globals that aren't used.
Catena4450
, etc., has agetPlatformTable()
method that returns the platforms supported by the device.STM32 classes instead have a table that's constructed with
#if
. This is much more fragile.Please refactor the Stm32 classes to use the Samd21 technique.
The text was updated successfully, but these errors were encountered: