Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unarmed damage does not benefit from vanilla minecraft crits #5056

Open
MrJezyk opened this issue Jul 22, 2024 · 2 comments
Open

Unarmed damage does not benefit from vanilla minecraft crits #5056

MrJezyk opened this issue Jul 22, 2024 · 2 comments

Comments

@MrJezyk
Copy link

MrJezyk commented Jul 22, 2024

As you probably know, in minecraft when you hit an enemy while falling or on the downward portion of your jump you do a critical hit that deals 50% extra damage.

For some reason the bonus damage from unarmed levels is not affected by these crits. When critting mobs it deals the same damage as a normal hit with unarmed.

@nossr50
Copy link
Member

nossr50 commented Jul 27, 2024

There's nothing in the code that I can think of that would affect this, unless unarmed attacks don't benefit from crits in vanilla?

@MrJezyk
Copy link
Author

MrJezyk commented Jul 30, 2024

I've looked into it a little and it appears bonus damage from enchantments does not benefit from crit damage (but bonus damage from strength does).

So for example an unenchanted diamond sword does (1 + 7) = 8 damage
an unenchanted diamond sword crit deals ((1 + 7) * 1,5)= 12 damage
sharpness V diamond sword deals ((1 + 7) + 3)= 11 damage
sharpness V diamond sword crit deals ((1 + 7) * 1,5 + 3)= 15 damage
sharpness V diamond sword with strength 2 crit deals (((1 + 6) + 7) * 1,5 + 3) = 24 damage
In this last formula the 1 is the base damage, the 6 is the extra base damage from strength, the 7 is the bonus damage from the sword, the 1,5 multiplier is from the crit and the 3 bonus damage is from the enchantment.

In this example I used a diamond sword but the same goes for unarmed except it doesn't have the +7 bonus the diamond sword gets.

I guess the extra damage gained from unarmed counts as enchantment damage instead of increasing the empty hands base damage.

I don't really know if this can be fixed but I figured I'd at least inform you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants