Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More configurations for Gitlab decoration #101

Closed
bmaehr opened this issue Feb 25, 2020 · 6 comments
Closed

More configurations for Gitlab decoration #101

bmaehr opened this issue Feb 25, 2020 · 6 comments
Labels
question Further information is requested

Comments

@bmaehr
Copy link

bmaehr commented Feb 25, 2020

After getting the plugin to work (master with sonarqube 8.0) I started to extend the Gitlab decoration plugin. The implemented features are:

  • Compact issue commenting (only one line)
  • Switch to turn off failing of pipeline (if quality gate is not reached it is not possible to merge, which is to hard for us)
  • Filtering by severity which issues are added to MR
  • If possible modification of comment instead of deleting and recreating (keeps comments and resolved status)

The problem is, that I did a refactoring of the whole class GitlabServerPullRequestDecorator because the main method was so long. How should I proceed?

@bmaehr
Copy link
Author

bmaehr commented Feb 25, 2020

@bmaehr
Copy link
Author

bmaehr commented Feb 25, 2020

"How should I proceed?": One MR, multiple MR, ....

@bmaehr
Copy link
Author

bmaehr commented Feb 25, 2020

image
image

@bmaehr
Copy link
Author

bmaehr commented Feb 25, 2020

image
image
image

@mc1arke
Copy link
Owner

mc1arke commented Feb 25, 2020

If you can break the work up until multiple commits (ideally one per change you've listed above) then that makes it easier to review. Ideally, also submitting an MR per feature means it's easier to discuss the intent of that feature individually, rather then have diverging conversations on a single MR.

@mc1arke mc1arke added the question Further information is requested label Feb 25, 2020
@bmaehr bmaehr closed this as completed Feb 25, 2020
@bmaehr
Copy link
Author

bmaehr commented Mar 22, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants