-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More configurations for Gitlab decoration #101
Comments
"How should I proceed?": One MR, multiple MR, .... |
If you can break the work up until multiple commits (ideally one per change you've listed above) then that makes it easier to review. Ideally, also submitting an MR per feature means it's easier to discuss the intent of that feature individually, rather then have diverging conversations on a single MR. |
https://github.com/bmaehr/sonarqube-community-branch-plugin/commits/master Will do some MR during the next days. |
After getting the plugin to work (master with sonarqube 8.0) I started to extend the Gitlab decoration plugin. The implemented features are:
The problem is, that I did a refactoring of the whole class GitlabServerPullRequestDecorator because the main method was so long. How should I proceed?
The text was updated successfully, but these errors were encountered: