Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can’t fetch URLs that don’t have .shp/.dbf extensions. #63

Open
mbostock opened this issue Mar 2, 2020 · 2 comments
Open

Can’t fetch URLs that don’t have .shp/.dbf extensions. #63

mbostock opened this issue Mar 2, 2020 · 2 comments

Comments

@mbostock
Copy link
Owner

mbostock commented Mar 2, 2020

Testing for .shp or .dbf at the end isn’t a good test for URLs. For example, it means you can’t pass a URL to an Observable FileAttachment (because those never have the .shp extension, and adding the .shp extension breaks the URL).

I think we should probably get rid of this magic. It might be okay to replace .shp with .dbf if the dbf argument is undefined, but otherwise I think we should leave the URLs as-is.

@polkerty
Copy link

Second this motion

@chadRoberge
Copy link

Not that it needs a third but....Third this motion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants