Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node12 is deprecated #4

Closed
WtfJoke opened this issue Aug 14, 2023 · 10 comments
Closed

Node12 is deprecated #4

WtfJoke opened this issue Aug 14, 2023 · 10 comments

Comments

@WtfJoke
Copy link

WtfJoke commented Aug 14, 2023

Hey @mbogh

Thank you for creating this action :)

The action currently still runs on node12. Node12 is eol and soon Node16.
Would be great if you can release a node16 version.

The following actions uses node12 which is deprecated and will be forced to run on node16: mbogh/test-ssl-action@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

grafik

EDIT: Will be fixed with #3

@mbogh
Copy link
Owner

mbogh commented Aug 14, 2023

Hi @WtfJoke, thanks for the issue, think I will go for Node18, just to be a bit more future proof :)

Will fix it later today

@mbogh
Copy link
Owner

mbogh commented Aug 15, 2023

Closed by #6 and available in v3

@mbogh mbogh closed this as completed Aug 15, 2023
@WtfJoke
Copy link
Author

WtfJoke commented Aug 15, 2023

Thank you!

@spaze
Copy link
Contributor

spaze commented Aug 15, 2023

Thanks for the new release! 🥳

Btw, seems like it's still node16, not 18, hope it's intentional. (update: it is 8b4c3ec)

@WtfJoke
Copy link
Author

WtfJoke commented Sep 13, 2023

Since node16 is now eol, just wanted to let you know, you can use node20 now :)

See actions/runner#2619 (comment)

There seems to be however no official anouncement/docs update yet

@mbogh
Copy link
Owner

mbogh commented Sep 14, 2023

Thanks I will try to update to node20, it failed last time 👯

@mbogh
Copy link
Owner

mbogh commented Sep 14, 2023

It is now done, also updated v3 to point to v3.0.1

@WtfJoke
Copy link
Author

WtfJoke commented Sep 14, 2023

Awesome, thank you

@SchoNie
Copy link

SchoNie commented Mar 11, 2024

Hello @mbogh,

Thanks for creating this action!

The v3 and v3.0.1 still point to d48191d with node16.
While the update and main branch with node20 is 2 commits ahead of the tagged version.
So the tagged actions even 3.0.1 uses node16 and gives the warning.

I am currently using: mbogh/test-ssl-action@6bad4e83e29bca36d5570a00736a0b9d63e52643 which works, but would be nice if you could tag the correct commit.

@mbogh
Copy link
Owner

mbogh commented Mar 12, 2024

Hello @mbogh,

Thanks for creating this action!

The v3 and v3.0.1 still point to d48191d with node16. While the update and main branch with node20 is 2 commits ahead of the tagged version. So the tagged actions even 3.0.1 uses node16 and gives the warning.

I am currently using: mbogh/test-ssl-action@6bad4e83e29bca36d5570a00736a0b9d63e52643 which works, but would be nice if you could tag the correct commit.

Added a new v3.0.2 and update v3 to point to same hash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants