Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakage due to quote_value signature changes in Rails 4.1 #427

Closed
ghost opened this issue Nov 19, 2013 · 5 comments
Closed

Breakage due to quote_value signature changes in Rails 4.1 #427

ghost opened this issue Nov 19, 2013 · 5 comments

Comments

@ghost
Copy link

ghost commented Nov 19, 2013

As of rails/rails@31a43eb (which is in Rails master now), the Active Record quote_value method is enforcing the requirement to send a column. acts-as-taggable-on calls quote_value with no column multiple times in core.rb and so is not functioning properly in Rails master.

It's possible that just passing nil for a column will work for the short run, but I haven't had time to verify this.

@ghost
Copy link
Author

ghost commented Nov 19, 2013

Quick and dirty fix at https://github.com/ffmike/acts-as-taggable-on/commit/076ff91ccdc1b307e698ee0d9a78dfc36cdfbe6b is enough to get past this in my particular project - MySQL, no funny column names. It is not tested in any other circumstances.

@bf4
Copy link
Collaborator

bf4 commented Dec 11, 2013

Now I need to go review #431 which I just merged...

Could you give a test example for this bug?

@bf4
Copy link
Collaborator

bf4 commented Jan 2, 2014

Is this fixed?

@ghost
Copy link
Author

ghost commented Jan 2, 2014

Just checked with 3.0.0 vs the current Rails master. In my project that's a working combination. I don't have time to dig back and see what change made the difference, but it does look like this is OK now.

@ghost ghost closed this as completed Jan 2, 2014
@bf4
Copy link
Collaborator

bf4 commented Jan 2, 2014

Great!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant