From e2bf36f6c0127cebd1761a50dee85c6caa37bec8 Mon Sep 17 00:00:00 2001 From: Mike Bland Date: Thu, 28 Dec 2023 19:22:07 -0500 Subject: [PATCH] End run-tests, publish-test-results actions early The publish-test-results GitHub Actions workflow would keep running even if it failed to download artifacts. run-tests would try to post coverage even if tests failed, when there was no coverage/lcov.info to send. This change now prevents both of those steps from taking place if an earlier step failed. --- .github/workflows/publish-test-results.yaml | 1 - .github/workflows/run-tests.yaml | 1 - 2 files changed, 2 deletions(-) diff --git a/.github/workflows/publish-test-results.yaml b/.github/workflows/publish-test-results.yaml index 7479ecc..08faf1d 100644 --- a/.github/workflows/publish-test-results.yaml +++ b/.github/workflows/publish-test-results.yaml @@ -38,7 +38,6 @@ jobs: - name: Post test report uses: dorny/test-reporter@v1 - if: always() with: name: Test Results path: 'TESTS-TestSuites.xml' diff --git a/.github/workflows/run-tests.yaml b/.github/workflows/run-tests.yaml index 9059bf9..a1ec5f1 100644 --- a/.github/workflows/run-tests.yaml +++ b/.github/workflows/run-tests.yaml @@ -46,6 +46,5 @@ jobs: - name: Send test coverage to Coveralls.io uses: coverallsapp/github-action@v2 - if: always() with: file: 'coverage/lcov.info'