Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't encode bools, ints, and doubles as strings #86

Closed
jdreaver opened this issue Mar 18, 2018 · 0 comments
Closed

Don't encode bools, ints, and doubles as strings #86

jdreaver opened this issue Mar 18, 2018 · 0 comments

Comments

@jdreaver
Copy link
Contributor

I was always under the impression that Bool, Int, and Double must be encoded as JSON strings in CloudFormation. Apparently that is not the case, see #85 (comment).

We could probably change the ToJSON definitions of everything to not use Bool', Integer', and Double'. Then, in the FromJSON instances for those aforementioned types, we can try to decode as a JSON number/bool, and if that fails try to decode from a JSON string.

We'll also have to test this on a lot of nontrivial templates. As long as the JSON spec document is accurate with types (hah! wouldn't that be nice...) there shouldn't be issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant