Abort on active rspec --focus option

[mockdeep]

When I add the following config to my spec_helper file all mutations fail except the noop:

config.filter_run :focus => true

[mockdeep]

I don't have any specs tagged with focus: true.

[mbj]

This is expected behavior and the way rspec works. I cannot fix it?

[mockdeep]

@mbj Why is this expected? I don't see why mutant should be incompatible with some rspec configurations.

[mbj]

@mockdeep Rspec filters example groups internally when :focus is enabled. Mutant does not "see" non-focus examples in that case. I'm already hooking deep into rspec, and I'd dislike this. I'll come up with a totally different integration scheme soon, that will probably fix these issues. Ideas are already there.

[mockdeep]

@mbj Is this the case when no examples are focused, though? I haven't marked any examples as focused, I've just enabled the configuration setting in spec_helper.

[djbender]

this bit me too, maybe a bit in the README would help?

[mbj]

@djbender We should add a note to the README, and we could peek into active rspec configuration to make mutant complain when this flag was set. I'd accept PRs for both.

I'll not close this issue until mutant complains when rspec is in invalid state for mutant integration.

[mbj]

@djbender I meant: Do you wana PR the README change?

[djbender]

When I get some free time I'll take a look!! thanks for the quick response.

[backus]

Not usually one to bump issues, but I got burned by this for like an hour since I had a totally unrelated spec focused and mutant reports the selected tests as having run. Would good be a nice thing to fix. I'd be happiest with something that aborts if the selected tests gets filtered down to zero when focus filter is applied

[mbj]

@backus same here, so will definitively add it soon thanks for bumping. I'm getting more and more mutant time recently.

[mbj]

8y ;)

[mbj]

@backus, @dgollahon

I opted for doing something "generic", not scoped to rspec/minitest integrations but simply: Whenever you request mutant to run on 0 effective tests: It prints a nice warning message aborting early.

Next step is to print the message on 0 selected tests.

[mbj]

@backus it could actually be you need a slight change from what I did, in making mutant complain on having 0 selected tests, as the focus option may keep 1-2 tests of 1k in?