Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TIME_PER_COMMAND a parameter instead of a constant #9

Closed
hbldh opened this issue Aug 15, 2016 · 2 comments
Closed

Make TIME_PER_COMMAND a parameter instead of a constant #9

hbldh opened this issue Aug 15, 2016 · 2 comments

Comments

@hbldh
Copy link
Contributor

hbldh commented Aug 15, 2016

In src/metawear/core/cpp/constant.h the value is hard coded to 150. This value is used in mbl_mw_metawearboard_initialize and makes the initialization fail when I use the library.

During the writing and notification exchange during initialization I get a status 16 response and initialization breaks. When changing the value to >250, then everything works fine and initialization is completed successfully.

Is it possible to make TIME_PER_COMMAND into parameter to set instead of a constant? Or at least bump it to >250?

@scaryghost
Copy link
Contributor

Increasing the constant to 250ms is fine. I don't want it set too high or else the initialization timeout will end up being 15+ seconds which is over kill.

@hbldh
Copy link
Contributor Author

hbldh commented Aug 16, 2016

I understand and agree. Currently I replace 150 with 300 before compiling MetaWear-CppAPI, so there is no immediate need to bump it to a higher value just to get something to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants