Add getWithPrefixLen method #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And remove uncrustify config.
oschwald
force-pushed
the
greg/network
branch
2 times, most recently
from
4647b25 to
6fa5e55
Compare
This still needs to normalize the prefix lengths for IPv4 lookups in IPv6 databases.
oschwald
force-pushed
the
greg/network
branch
from
6fa5e55 to
3b36e9c
Compare
horgh
requested changes
Sep 27, 2019
| } | ||
| $tempBit = 0xFF & $rawAddress[$i >> 3]; | ||
| for ($i = 0; $i < $bitCount && $node < $nodeCount; ++$i) { | ||
| $tempBit = 0xFF & $rawAddress[($i >> 3) + 1]; |
There was a problem hiding this comment.
Why +1? Oh... the array is starting at 1 😕
ext/maxminddb.c
Outdated
| THROW_EXCEPTION("InvalidArgumentException", | ||
| "The value \"%s\" is not a valid IP address.", | ||
| ip_address); | ||
| return; | ||
| } | ||
| if (!addresses && !addresses->ai_addr) { |
README.md
Outdated
| ## Installation (RPM) | ||
|
|
||
| RPMs are available in the [official Fedora repository](https://apps.fedoraproject.org/packages/php-maxminddb) | ||
| and in [Remi's RPM repository](https://rpms.remirepo.net/rpmphp/zoom.php?rpm=python-maxminddb). |
There was a problem hiding this comment.
Gah. I can't find a good link. I'll just leave it off.
horgh
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #60.