Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.4.0] Test failure on 32-bit #79

Closed
remicollet opened this issue Nov 21, 2018 · 1 comment
Closed

[1.4.0] Test failure on 32-bit #79

remicollet opened this issue Nov 21, 2018 · 1 comment

Comments

@remicollet
Copy link
Contributor

Test suite ok without the extension

With the extension

There was 1 failure:
1) MaxMind\Db\Test\Reader\ReaderTest::testDecoder
Failed asserting that 268435456 is identical to '268435456'.
/builddir/build/BUILD/MaxMind-DB-Reader-php-2f1086e38939e808cc23b17daa469da094af9125/tests/MaxMind/Db/Test/ReaderTest.php:57
FAILURES!
@remicollet remicollet reopened this Nov 22, 2018
@oschwald
Copy link
Member

Thanks for reporting this. I wish Travis had 32 bit images so we could automate the testing of the various cases.

oschwald added a commit that referenced this issue Jan 3, 2019
@oschwald
Fix extension for large uint32 values on 32 bit machines
f144011 
This also updates the extension to return an integer for uint64 values that are
less than LONG_MAX.

Closes #79.
oschwald added a commit that referenced this issue Jan 3, 2019
@oschwald
Fix extension for large uint32 values on 32 bit machines
af180fc 
This also updates the extension to return an integer for uint64 values that are
less than LONG_MAX.

Closes #79.
oschwald added a commit that referenced this issue Jan 3, 2019
@oschwald
Fix extension for large uint32 values on 32 bit machines
ae069c9 
This also updates the extension to return an integer for uint64 values that are
less than LONG_MAX.

Closes #79.
oschwald added a commit that referenced this issue Jan 3, 2019
@oschwald
Fix extension for large uint32 values on 32 bit machines
04d2fab 
This also updates the extension to return an integer for uint64 values that are
less than LONG_MAX.

Closes #79.
@oschwald oschwald mentioned this issue Jan 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@remicollet @oschwald