Test failures on 32-bit

[remicollet]

Everything OK on 64-bit

On 32-bit (yes this still exists...)

There were 4 failures:
1) MaxMind\Db\Test\Reader\DecoderTest::testPointers
decoded pointers - 1
Failed asserting that -1 is identical to 4294967295.0.
/builddir/build/BUILD/MaxMind-DB-Reader-php-e042b4f8a2dff41e19019faf16427178b07fbd58/tests/MaxMind/Db/Test/Reader/DecoderTest.php:371
/builddir/build/BUILD/MaxMind-DB-Reader-php-e042b4f8a2dff41e19019faf16427178b07fbd58/tests/MaxMind/Db/Test/Reader/DecoderTest.php:349
/builddir/build/BUILD/MaxMind-DB-Reader-php-e042b4f8a2dff41e19019faf16427178b07fbd58/tests/MaxMind/Db/Test/Reader/DecoderTest.php:307
2) MaxMind\Db\Test\Reader\DecoderTest::testUint32
decoded uint32 - 1
Failed asserting that -1 is identical to 4294967295.0.
/builddir/build/BUILD/MaxMind-DB-Reader-php-e042b4f8a2dff41e19019faf16427178b07fbd58/tests/MaxMind/Db/Test/Reader/DecoderTest.php:371
/builddir/build/BUILD/MaxMind-DB-Reader-php-e042b4f8a2dff41e19019faf16427178b07fbd58/tests/MaxMind/Db/Test/Reader/DecoderTest.php:349
/builddir/build/BUILD/MaxMind-DB-Reader-php-e042b4f8a2dff41e19019faf16427178b07fbd58/tests/MaxMind/Db/Test/Reader/DecoderTest.php:322
3) MaxMind\Db\Test\Reader\DecoderTest::testUint64
decoded uint64 - 1
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-4294967295
+-1
/builddir/build/BUILD/MaxMind-DB-Reader-php-e042b4f8a2dff41e19019faf16427178b07fbd58/tests/MaxMind/Db/Test/Reader/DecoderTest.php:371
/builddir/build/BUILD/MaxMind-DB-Reader-php-e042b4f8a2dff41e19019faf16427178b07fbd58/tests/MaxMind/Db/Test/Reader/DecoderTest.php:338
/builddir/build/BUILD/MaxMind-DB-Reader-php-e042b4f8a2dff41e19019faf16427178b07fbd58/tests/MaxMind/Db/Test/Reader/DecoderTest.php:327
4) MaxMind\Db\Test\Reader\DecoderTest::testUint128
decoded uint128 - 1
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-4294967295
+-1
/builddir/build/BUILD/MaxMind-DB-Reader-php-e042b4f8a2dff41e19019faf16427178b07fbd58/tests/MaxMind/Db/Test/Reader/DecoderTest.php:371
/builddir/build/BUILD/MaxMind-DB-Reader-php-e042b4f8a2dff41e19019faf16427178b07fbd58/tests/MaxMind/Db/Test/Reader/DecoderTest.php:338
/builddir/build/BUILD/MaxMind-DB-Reader-php-e042b4f8a2dff41e19019faf16427178b07fbd58/tests/MaxMind/Db/Test/Reader/DecoderTest.php:332
FAILURES!

[oschwald]

Thanks for reporting! To confirm, is this when using the pure PHP reader or the extension?

[remicollet]

Thanks for reporting! To confirm, is this when using the pure PHP reader or the extension?

The pure PHP reader

[remicollet]

Notice, with the extension enabled, test suite fails exactly the same way

[oschwald]

Thanks for checking that. Looking at the failure more closely, it looks like it is specific to the decoder class, which the extension doesn't have an equivalent to and is use internally by the pure PHP reader.