Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PECL package #34

Closed
slashterix opened this issue Dec 24, 2015 · 25 comments
Closed

PECL package #34

slashterix opened this issue Dec 24, 2015 · 25 comments

Comments

@slashterix
Copy link

Should this be added to the PECL repository for easy download and access?

@oschwald
Copy link
Member

oschwald commented Mar 4, 2016

We started the process to make this into a PECL a while back, but no one offered to sponsor us. Also, this extension isn't the greatest fit for PECL due to its dependency on pure PHP code. We have been hoping that Composer would get extension support as this would be much preferable.

@chasebolt
Copy link

I too would like to see this in PECL 👍

@demofly
Copy link

demofly commented Apr 27, 2016

Hi there! When it will be in PECL?

@jbboehr
Copy link
Contributor

jbboehr commented Nov 18, 2016

@oschwald I've recently obtained a PECL account. I think I'm able to sponsor you even though I'm a new user, although I don't think I'm able to approve the account request, if you're still interested.

@oschwald
Copy link
Member

@jbboehr, thanks! That might be helpful. I'll look into it again after the Black Friday / Cyber Monday rush.

@kabudu
Copy link

kabudu commented Jun 16, 2017

any update on getting this into PECL?

@Gemorroj
Copy link

@oschwald Is PECL still supported?

@oschwald
Copy link
Member

PECL has never been supported for this library. Ideally, Composer would get some sort of meaningful support for extensions, e.g., using Pickle. Having the current extension in PECL isn't ideal unless we make it completely independent of the PHP code in this repo.

@remicollet
Copy link
Contributor

I really think having such extension on PECL is useful, at least it will give it much more visibility.
And probably, I can also be a sponsor if needed

its dependency on pure PHP code.

Indeed, the metadata method is really strange, having to call pure PHP code.
Shouldn't this method return raw data, and then the pure PHP library can use it ?

@szepeviktor
Copy link

Having a composer package and a PECL extension in one repo may hold back both software.

@TBK
Copy link

TBK commented Feb 24, 2020

Any update on this issue?

@oschwald
Copy link
Member

There are no immediate plans. I think to make this really work as a PECL package, we would want the extension to not depend on any of the pure PHP code (e.g., for exceptions). Once that is done, we could look into getting this on PECL.

@mkormendy
Copy link

@remicollet is correct, adding this to PECL doesn't require pure PHP code specifically, it would just return the raw data, and then the pure PHP library can use it.

@oschwald
Copy link
Member

As mentioned above, we would need to remove the use of the pure PHP classes from this extension. Ideally, we would just port them to the extension so that there are no API changes.

@oschwald
Copy link
Member

I think we are ready to pursue this again. Last time we tried, we didn't get any offers for sponsorship. @jbboehr or @remicollet, are either of you still willing to serve as a sponsor? Thanks!

@remicollet
Copy link
Contributor

remicollet commented Jul 28, 2020

Yes I can help with publishing this extension on pecl (but probably after my holidays...)

@oschwald
Copy link
Member

@remicollet, thanks! I'll go ahead and apply for an account with you as a sponsor. Once I have that, I am sure there will be follow-up questions and advice that I will need, but that can wait until after your holidays.

@remicollet
Copy link
Contributor

remicollet commented Aug 4, 2020

Per new extension process, please send a email to pecl dev ML, introducing yourself and the extension.

https://pecl.php.net/account-request.php

@oschwald
Copy link
Member

oschwald commented Aug 4, 2020

Thanks! I did when we first pursued getting an account, but it looks like that was way back in 2013. 🙂

@oschwald
Copy link
Member

oschwald commented Sep 3, 2020

An update:

The intent was to release 1.7.0 as a PECL package, as the release notes suggest. However, we have run into some issues with the PECL servers rejecting the package for reason that are not clear to anyone. There is unfortunately no ETA on when this will be resolved.

@oschwald
Copy link
Member

oschwald commented Oct 2, 2020

The upload issue has been resolved and the package has been successfully uploaded. 🎆

@oschwald oschwald closed this as completed Oct 2, 2020
@szepeviktor
Copy link

Thank you @oschwald

This is very normal :) https://pecl.php.net/package/maxminddb

@mlocati
Copy link
Contributor

mlocati commented Dec 10, 2020

Thank you very much for this! Adding support for the maxminddb PECL package to my docker PHP extension installer script has been a piece of cake.

@kocoten1992
Copy link

it doesnt work for me:

pecl install maxminddb
...
running: make
/bin/bash /tmp/pear/temp/pear-build-rootA7YtBy/maxminddb-1.8.0/libtool --mode=compile cc  -I. -I/tmp/pear/temp/maxminddb/ext -DPHP_ATOM_INC -I/tmp/pear/temp/pear-build-rootA7YtBy/maxminddb-1.8.0/include -I/tmp/pear/temp/pear-build-rootA7YtBy/maxminddb-1.8.0/main -I/tmp/pear/temp/maxminddb/ext -I/usr/include/php/20190902 -I/usr/include/php/20190902/main -I/usr/include/php/20190902/TSRM -I/usr/include/php/20190902/Zend -I/usr/include/php/20190902/ext -I/usr/include/php/20190902/ext/date/lib  -DHAVE_CONFIG_H  -g -O2   -c /tmp/pear/temp/maxminddb/ext/maxminddb.c -o maxminddb.lo
libtool: compile:  cc -I. -I/tmp/pear/temp/maxminddb/ext -DPHP_ATOM_INC -I/tmp/pear/temp/pear-build-rootA7YtBy/maxminddb-1.8.0/include -I/tmp/pear/temp/pear-build-rootA7YtBy/maxminddb-1.8.0/main -I/tmp/pear/temp/maxminddb/ext -I/usr/include/php/20190902 -I/usr/include/php/20190902/main -I/usr/include/php/20190902/TSRM -I/usr/include/php/20190902/Zend -I/usr/include/php/20190902/ext -I/usr/include/php/20190902/ext/date/lib -DHAVE_CONFIG_H -g -O2 -c /tmp/pear/temp/maxminddb/ext/maxminddb.c  -fPIC -DPIC -o .libs/maxminddb.o
/tmp/pear/temp/maxminddb/ext/maxminddb.c:27:10: fatal error: maxminddb.h: No such file or directory
   27 | #include <maxminddb.h>
      |          ^~~~~~~~~~~~~
compilation terminated.
make: *** [Makefile:192: maxminddb.lo] Error 1
ERROR: `make' failed

@mlocati
Copy link
Contributor

mlocati commented Jan 5, 2021

@kocoten1992 you need to install the libmaxminddb-dev system package (apt-get install libmaxminddb-dev on debian/ubuntu, apk add libmaxminddb-dev on alpine).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests