-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PECL package #34
Comments
We started the process to make this into a PECL a while back, but no one offered to sponsor us. Also, this extension isn't the greatest fit for PECL due to its dependency on pure PHP code. We have been hoping that Composer would get extension support as this would be much preferable. |
I too would like to see this in PECL 👍 |
Hi there! When it will be in PECL? |
@oschwald I've recently obtained a PECL account. I think I'm able to sponsor you even though I'm a new user, although I don't think I'm able to approve the account request, if you're still interested. |
@jbboehr, thanks! That might be helpful. I'll look into it again after the Black Friday / Cyber Monday rush. |
any update on getting this into PECL? |
@oschwald Is PECL still supported? |
PECL has never been supported for this library. Ideally, Composer would get some sort of meaningful support for extensions, e.g., using Pickle. Having the current extension in PECL isn't ideal unless we make it completely independent of the PHP code in this repo. |
I really think having such extension on PECL is useful, at least it will give it much more visibility.
Indeed, the metadata method is really strange, having to call pure PHP code. |
Having a composer package and a PECL extension in one repo may hold back both software. |
Any update on this issue? |
There are no immediate plans. I think to make this really work as a PECL package, we would want the extension to not depend on any of the pure PHP code (e.g., for exceptions). Once that is done, we could look into getting this on PECL. |
@remicollet is correct, adding this to PECL doesn't require pure PHP code specifically, it would just return the raw data, and then the pure PHP library can use it. |
As mentioned above, we would need to remove the use of the pure PHP classes from this extension. Ideally, we would just port them to the extension so that there are no API changes. |
I think we are ready to pursue this again. Last time we tried, we didn't get any offers for sponsorship. @jbboehr or @remicollet, are either of you still willing to serve as a sponsor? Thanks! |
Yes I can help with publishing this extension on pecl (but probably after my holidays...) |
@remicollet, thanks! I'll go ahead and apply for an account with you as a sponsor. Once I have that, I am sure there will be follow-up questions and advice that I will need, but that can wait until after your holidays. |
Per new extension process, please send a email to pecl dev ML, introducing yourself and the extension. |
Thanks! I did when we first pursued getting an account, but it looks like that was way back in 2013. 🙂 |
An update: The intent was to release 1.7.0 as a PECL package, as the release notes suggest. However, we have run into some issues with the PECL servers rejecting the package for reason that are not clear to anyone. There is unfortunately no ETA on when this will be resolved. |
The upload issue has been resolved and the package has been successfully uploaded. 🎆 |
Thank you @oschwald This is very normal :) https://pecl.php.net/package/maxminddb |
Thank you very much for this! Adding support for the |
it doesnt work for me:
|
@kocoten1992 you need to install the |
Should this be added to the PECL repository for easy download and access?
The text was updated successfully, but these errors were encountered: