Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window does not always open/close when icon is clicked #116

Open
jdp opened this issue Apr 6, 2016 · 1 comment
Open

Window does not always open/close when icon is clicked #116

jdp opened this issue Apr 6, 2016 · 1 comment

Comments

@jdp
Copy link

jdp commented Apr 6, 2016

Reproduced with the example app, menubar from git checkout (a6afe2e) on Mac OS X 10.10.5.

The window does not always open or close when the icon in the menu bar is clicked. Sometimes it takes 5 or 6 clicks before the window responds. I also noticed that the icon doesn't stay highlighted when the window is open, where other menu bar apps keep the icon highlighted.

@mbruschi
Copy link

mbruschi commented Aug 3, 2016

I debugged this a bit and it seems that it is not a problem of menubar but a problem from electronjs itself.

In line 67 of the index.js menubar.windows.isVisible() is called and sometimes it returns true even if the window is not visible and then hideWindow() instead of showWindow() is called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants