You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Let's say I have x.zip with contains a symlink and I unzip the first time to /foo.
If I try to unzip the same zip (or another zip containing the same symlink) to /foo it will fail with EEXIST. Regular files overwrite as expected (ie fs.writestream by default will overwrite). Unfortunately fs.symlink fails if the symlink already exists.
I can make a PR but do you have any suggestions on how to proceed?
I was thinking we check if the symlink already exists and delete before creating the new symlink.
Furthermore - should overwrite be set by flag (for the regular files as well)?
The text was updated successfully, but these errors were encountered:
Let's say I have
x.zip
with contains a symlink and I unzip the first time to/foo
.If I try to unzip the same zip (or another zip containing the same symlink) to
/foo
it will fail withEEXIST
. Regular files overwrite as expected (iefs.writestream
by default will overwrite). Unfortunatelyfs.symlink
fails if the symlink already exists.I can make a PR but do you have any suggestions on how to proceed?
I was thinking we check if the symlink already exists and delete before creating the new symlink.
Furthermore - should overwrite be set by flag (for the regular files as well)?
The text was updated successfully, but these errors were encountered: