Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Interface Threading is Incorrect #11598

Open
HTRamsey opened this issue Jun 3, 2024 · 0 comments
Open

Link Interface Threading is Incorrect #11598

HTRamsey opened this issue Jun 3, 2024 · 0 comments
Assignees

Comments

@HTRamsey
Copy link
Collaborator

HTRamsey commented Jun 3, 2024

The QThread subclassing in the LinkInterfaces is incorrect and is probably causing various difficult to trace issues. ADSBTCPLink as well. None of these should call moveToThread(this). A worker class or QtConcurrent::run can be used for the MockLink, while the rest are fine with signals/slots as they use asynchronous functions (except for one in TCPLink).

Also Avoid shared_ptr with QObjects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant