This repository has been archived by the owner on Mar 2, 2024. It is now read-only.
add generic analytics section for segment compatible api #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-newman
force-pushed
the
segment-to-rudderstack
branch
from
6569f72
to
d401db4
Compare
tulir
reviewed
Oct 9, 2023
There was a problem hiding this comment.
What happened to segment.py 🤔 (or more specifically, why did nothing happen to it)?
There was a problem hiding this comment.
Nice spot! I thought I had deleted that file.
mautrix_instagram/web/analytics.py
Outdated
| if not host or not key: | ||
| return | ||
| global analytics_url, analytics_token, analytics_user_id, http | ||
| analytics_url = urlunparse(("https", host, "/v1/track", "", "", "")) |
tulir
approved these changes
Oct 9, 2023
|
Thanks for the review @tulir |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.