Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would you be open to a PR changing from grid layout to flexbox layout? #60

Open
kshannoninnes opened this issue Jun 28, 2024 · 4 comments

Comments

@kshannoninnes
Copy link

Love the minimalist style, but it's bothering me that the content div is overflowing and creating a scrollbar. I've looked through the stylesheet a bit and played around, and I believe the cause is due to the way the grid layout is used (although I'm not 100% on this).

If you prefer to stay with the grid style, that's cool. I'll keep my forked version for my own usage.

@matze
Copy link
Owner

matze commented Jun 28, 2024

Do you have some example how you would like to have it? Not sure what the layout change would look like.

@kshannoninnes
Copy link
Author

kshannoninnes commented Jun 29, 2024

On further investigation I believe the scrollbar is actually mostly due to the way you've implemented the select box for languages. I'm not sure if there's a way to apply a dynamic size in this case, as 23 (with the spacing between elements in that right-menu) is too large and introduces a page scrollbar (screenshot below).

I think there are a couple potential ways of solving my issue.

  • Re-design the right menu to use actual dropdown select boxes instead of the current list style
  • Change the size element (and make some height attribute changes to a few other elements) to a lower number

I don't think any of the suggestions are good ones. It might be best for me to just keep a forked version for myself? Open to ideas. I've included a screenshot of the second option of changes that I implemented on my own copy below (ignore the random artifacts in the bottom right, that's the old screenshot behind it in paint).

Here's a link to my fork commit for the changes that achieve the second screenshot: kshannoninnes@238e53d

image
image

@matze
Copy link
Owner

matze commented Jun 29, 2024

I'm fine reducing the size again. In fact the list used to be shorter.

@matze
Copy link
Owner

matze commented Jun 30, 2024

This can be closed then, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants