Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two minor issues: Change server.js and Circular dependency #5

Open
christofer-f opened this issue May 14, 2020 · 0 comments
Open

Two minor issues: Change server.js and Circular dependency #5

christofer-f opened this issue May 14, 2020 · 0 comments

Comments

@christofer-f
Copy link

christofer-f commented May 14, 2020

Hi and thanks for a great template.

I have two small things...

  1. Perhaps the server.js could reflect the latest official server.js and only import the tailwind.css
    like this:

import sirv from 'sirv';
import polka from 'polka';
import compression from 'compression';
import * as sapper from '@sapper/server';

import "./tailwind.css";

const { PORT, NODE_ENV } = process.env;
const dev = NODE_ENV === 'development';

polka() // You can also use Express
.use(
compression({ threshold: 0 }),
sirv('static', { dev }),
sapper.middleware()
)
.listen(PORT, err => {
if (err) console.log('error', err);
});

  1. I get the following warnings:
    • client Circular dependency: src\node_modules\@sapper\app.mjs -> src\node_modules\@sapper\internal\App.svelte -> src\routes\_layout.svelte -> src\node_modules\@sapper\app.mjs • server Circular dependency: src\routes\_layout.svelte -> src\node_modules\@sapper\app.mjs -> src\node_modules\@sapper\internal\App.svelte -> src\routes\_layout.svelte Circular dependency: src\routes\_layout.svelte -> src\node_modules\@sapper\app.mjs -> src\node_modules\@sapper\internal\manifest-client.mjs -> src\routes\_layout.svelte ✔
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant