(#6) Add solution for favicon #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ohp, gotta add a gpg signature, derp. |
Prior to this commit the favicon for a castanet site was not set by the theme. This commit adds a tag for the favicon to the header partial, defaulting to `icons/favicon.ico` but allowing an override in the site configuration. Resolves #6 Signed-off-by: Michael T Lombardi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit the favicon for a castanet site was
not set by the theme. This commit adds a tag for the
favicon to the header partial, defaulting to
icons/favicon.icobut allowing an override in the site configuration.
Resolves #6
This change is