Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create solution for favicon #6

Closed
2 tasks
mattstratton opened this issue Sep 22, 2016 · 0 comments
Closed
2 tasks

Create solution for favicon #6

mattstratton opened this issue Sep 22, 2016 · 0 comments
Assignees
@mattstratton
Labels
enhancement

Comments

@mattstratton
Copy link
Owner

  • Provide documentation on how to create them and place them in the /static/icons directory.
  • Putconditional code in head_includes.html to check to see if favicon is set in config.toml and if so, then add all the code for it.
@mattstratton mattstratton modified the milestones: v.2.0, v.1.0 Sep 25, 2016
@mattstratton mattstratton self-assigned this Sep 25, 2016
@mattstratton mattstratton modified the milestones: 1.0, Next Tasks May 30, 2017
@mattstratton mattstratton removed the ready label Jun 9, 2017
@mattstratton mattstratton removed this from the Next Tasks milestone Feb 10, 2018
@michaeltlombardi michaeltlombardi mentioned this issue May 14, 2018
Merged
mattstratton pushed a commit that referenced this issue Aug 3, 2018
@michaeltlombardi @mattstratton
(#6) Add solution for favicon (#189)
43a3d45 
Prior to this commit the favicon for a castanet site was
not set by the theme. This commit adds a tag for the
favicon to the header partial, defaulting to `icons/favicon.ico`
but allowing an override in the site configuration.

Resolves #6

Signed-off-by: Michael T Lombardi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattstratton mattstratton

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mattstratton